Fixes to compile against the new libnetapi.so, radio search functionality restored, crashes fixed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity restored, check if iconUrl is empty before trying to download the icon (fixes crash)
…g Haiku coding style the if-else logic got messed up and StreamRadio was crashing when trying to load certain Station logos (will provide examples if needed)
humdingerb
reviewed
Feb 20, 2021
humdingerb
reviewed
Feb 20, 2021
pulkomandy
reviewed
Mar 6, 2021
| request.SetTimeout(10000); | ||
| request.SetDiscardData(true); | ||
| request.SetUserAgent("StreamRadio/0.0.4"); | ||
| BHttpRequest* request = dynamic_cast<BHttpRequest*>(BUrlProtocolRoster::MakeRequest(url.UrlString().String(), NULL)); |
There was a problem hiding this comment.
you are missing a delete request; at the end of the function, otherwise this will leak memory.
pulkomandy
reviewed
Mar 6, 2021
| @@ -194,31 +194,31 @@ HttpUtils::GetAll(BUrl url, BHttpHeaders* responseHeaders, bigtime_t timeOut, | |||
| return data; | |||
|
|
|||
| HttpIOReader reader(data, responseHeaders, sizeLimit); | |||
| HttpRequest request(url, false, "HTTP", &reader); | |||
| BHttpRequest* request = dynamic_cast<BHttpRequest*>(BUrlProtocolRoster::MakeRequest(url.UrlString().String(), &reader, NULL)); | |||
There was a problem hiding this comment.
you are missing a "delete request;" at the end of the function to avoid a memory leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network API has changed a couple of weeks ago. As a result, StreamRadio wasn't compiling anymore, at least on hrev54958, These changes allow StreamRadio to compile again, and, as a bonus, restore the radio search functionality that we missed at some point (using the package from Haiku Depot on hrev54598, at least).
While testing the app, I've discovered that it had a crash every time it tried to download a non-existent icon. The minor fix just checks if the BString that holds the icon URL is empty before proceeding with the download.
I've just realized that there's another PR waiting to be merged, but it seems that we didn't duplicate efforts and that one addresses different problems.