Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving inserted mutations/sequencing errors to a vcf file #250

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

ThijsMaas
Copy link
Collaborator

@ThijsMaas ThijsMaas commented Feb 5, 2024

The final feature that was requested is a record of all the sequencing errors that have been added to the reads during the simulation. I have made a new parameter that enables outputting these "mutations" to a VCF file.

@ThijsMaas ThijsMaas changed the title init storing mutations Saving inserted mutations/sequencing error to a vcf file Feb 5, 2024
@ThijsMaas ThijsMaas changed the title Saving inserted mutations/sequencing error to a vcf file Saving inserted mutations/sequencing errors to a vcf file Feb 5, 2024
@ThijsMaas ThijsMaas marked this pull request as ready for review February 5, 2024 18:58
Copy link
Collaborator

@StefanLelieveld StefanLelieveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! You've fixed the logging of the errors on the reversed reads too!

iss/error_models/__init__.py Outdated Show resolved Hide resolved
iss/app.py Show resolved Hide resolved
Copy link
Owner

@HadrienG HadrienG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@StefanLelieveld StefanLelieveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@HadrienG HadrienG merged commit e8ff9ca into dev Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants