Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MiSeq and NextSeq error models #249

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

StefanLelieveld
Copy link
Collaborator

Hi Hadrien,

I have added the new MiSeq and NextSeq models to the profiles-folder and made them available through the cli. Both the MiSeq and NextSeq error models produce paired-end reads of 301bp. The miSeq models are based on the reads of the 8 runs of SRA project ERP022313.

  • miSeq_0.npz --> filter: none
  • miSeq_20.npz --> filter: the forward and reverse read have a mean quality score >= 20
  • miSeq_24.npz --> filter: the forward and reverse read have a mean quality score >= 24
  • miSeq_28.npz --> filter: the forward and reverse read have a mean quality score >= 28
  • miSeq_32.npz --> filter: the forward and reverse read have a mean quality score >= 32
  • miSeq_36.npz --> filter: the forward and reverse read have a mean quality score >= 36
  • nextSeq.npz --> filter: none

Below are the placeholder-names that I have used for the error models in the cli. I am not very happy with the current names: it's not clear what the number means. At the same time I don't want to use very long and extensive names. The naming of the error models is open for discussion.

  • miSeq_0.npz --> "miseq"
  • miSeq_20.npz --> "miseq-20"
  • miSeq_24.npz --> "miseq-24"
  • miSeq_28.npz --> "miseq-28"
  • miSeq_32.npz --> "miseq-32"
  • miSeq_36.npz --> "miseq-36"
  • nextSeq.npz --> "nextseq"

Let me know what you think of it.

Best,
Stefan

iss/generator.py Outdated Show resolved Hide resolved
Copy link
Owner

@HadrienG HadrienG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about the model names and I don't think I have a much better naming scheme to propose.

Eventually could a q to make it a bit more obvious it's about the quality scores: miseq-q20 or miseq-q20+, but leaving them as is would be fine with me too.

@HadrienG
Copy link
Owner

Are we happy with the names and merging this?

@HadrienG HadrienG merged commit cd714b1 into dev Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants