-
Notifications
You must be signed in to change notification settings - Fork 33
[RUN-5386] Add chromeVersion property to getRuntimeInfo interface #368
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
Git
Asars used for testingTest results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add this to the docs too?
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
Git
Asars used for testingTest results
|
Description of Change
Add chromeVersion property to runtimeInfo interface
Checklist
npm test
passesRelease Notes
Notes: