Skip to content
This repository was archived by the owner on May 22, 2020. It is now read-only.

RUN-5679 BrowserView => View #982

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

RUN-5679 BrowserView => View #982

wants to merge 3 commits into from

Conversation

@pbaize
Copy link
Contributor

@pbaize pbaize commented Oct 4, 2019 •
edited
Loading

Description of Change

Rename public facing browserview. Goes with this pr HadoukenIO/js-adapter#358

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • automated tests are changed or added
  • manual tests are changed or added
  • relevant documentation is changed or added
  • PR title starts with the JIRA ticket pull request process
  • PR release notes describe the change in a way relevant to app-developers
  • Link to new tests added
  • PR has assigned reviewers

Release Notes

Notes:

@openfin-github-bot
Copy link

openfin-github-bot bot commented Oct 4, 2019

⚠️ Failed to build 033ae65

@openfin-github-bot openfin-github-bot bot added the auto testing failed Bot failed to build label Oct 4, 2019
@MichaelMCoates
Copy link
Contributor

MichaelMCoates commented Oct 7, 2019

build fail

@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing failed Bot failed to build labels Oct 7, 2019
@openfin-github-bot
Copy link

openfin-github-bot bot commented Oct 7, 2019

3d8a9bf

Git

  • core: develop <= RUN-5679 (3d8a9bf)
  • js-adapter: develop <= RUN-5679 (1418cc2)
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 7, 2019
@pbaize pbaize mentioned this pull request Oct 11, 2019
Closed
9 tasks
@openfin-github-bot openfin-github-bot bot added auto testing started Bot started automated testing and removed auto testing done Bot completed automated testing labels Oct 11, 2019
@openfin-github-bot
Copy link

openfin-github-bot bot commented Oct 11, 2019

be2a042

Git

  • core: develop <= RUN-5679 (be2a042)
  • js-adapter: develop <= RUN-5679 (17ea923)
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@rdepena rdepena rdepena approved these changes

@MichaelMCoates MichaelMCoates MichaelMCoates approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

auto testing done Bot completed automated testing cla-present

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbaize @MichaelMCoates @rdepena @finos-admin