[4.0] [PR 28722] Load client language file for com_contact in API submitt contact form #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was that really a good fix? |
Hackwar
pushed a commit
that referenced
this pull request
Dec 9, 2020
… and clean up sub-layouts (#45) * Separate link and button for dropdown items - Move dropdown handling to main layout override - Remove obsolete sub-layout overrides * Use language string for screenreader text * Add missing language string for frontend * Adapt metismenu scss to changed dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#28722.
Summary of Changes
This fixes that with PR joomla#28722, the subject and body language strings are not translated when sending a contact form email with the API.
See my comment there about the issue: joomla#28722 (comment).
But I don't know if it's the right way to fix it, so please check that and use a different solution for that problem if this here is wrong.