-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split vanillla object from levels allowing pruning vanilla assets on fast64 imports and managing vanilla objects independently of levels #796
base: develop/3.0.0
Are you sure you want to change the base?
Conversation
Important question, does this screw over 4MB users? |
Nope, in fact it should help 4MB users because levels will not have garbage in them with fast64 imports. |
Can you rebase this onto |
Rebased to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good grief, GitHub is really on the struggle bus with this one; I straight up had to skip the last entire quarter of files because GitHub stopped pre-loading diffs, and waiting for 200 them to load would literally take me all night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it :monkaS:
Do not merge till PR Fast-64/fast64#356 is in main |
someone should really merge that honestly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upstream fix seems to have been merged in so there should be no blockers here
Is there anything else here to be added to fast64, especially now that HackerSM64 detection is a thing that actually exists? |
This PR introduces a new bank for vanilla objects split from the courses. This allows for the following nice improvements:
From level script it looks like
Unfortunately, this PR is very gigantic and I am not sure I can do much about reducing its complextity but I would really appreciate if I can get this merged to make handling vanilla stuff significantly more convenient.