fix: correct type inheritance in CalendarContainer props #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CalendarContainerProps to extend HTMLAttributes<HTMLDivElement> instead of HTMLDivElement. This fixes the type definition to properly include all valid HTML attributes that can be passed to the div element, improving type safety and developer experience.
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@iskkiri you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5365 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 30 30
Lines 3358 3358
Branches 1428 1427 -1
=======================================
Hits 3253 3253
Misses 103 103
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5364
Problem
The
CalendarContainerPropsinterface currently extendsReact.PropsWithChildren<HTMLDivElement>, which causes TypeScript errors when using CalendarContainer in custom implementations. This incorrect type inheritance prevents proper type checking for HTML attributes.Changes
CalendarContainerPropsto extendReact.PropsWithChildren<React.HTMLAttributes<HTMLDivElement>>instead ofHTMLDivElementScreenshots
N/A
To reviewers
This is a type-only change that fixes TypeScript errors while maintaining the same runtime behavior. The change makes the type definition more accurate by properly inheriting HTML attribute types.
Contribution checklist