Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix TypeScript Linting warnings for React 19 upgrade #5301

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

balajis-qb
Copy link
Contributor

Closes #5299

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@balajis-qb you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 19
- 10

100% TSX

Type of change

Fix - These changes are likely to be fixing a bug or issue.

@martijnrusschen
Copy link
Member

Weird, there's no workflow being triggered. can you try force pushing the branch again?

@martijnrusschen
Copy link
Member

I think this looks good. Will merge this as this goes into my React 19 branch

@martijnrusschen martijnrusschen merged commit 011c335 into Hacker0x01:react-19 Jan 6, 2025
@balajis-qb
Copy link
Contributor Author

balajis-qb commented Jan 6, 2025

Weird, there's no workflow being triggered. can you try force pushing the branch again?

I think the GitHub workflow watches for the PR against the main branch alone. As I raised this PR to your feature branch, it's not triggered.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants