Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint9 #5168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Eslint9 #5168

wants to merge 4 commits into from

Conversation

martijnrusschen
Copy link
Member

Attempt to upgrade our ESlint config to the latest version.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 126
- 160

79% JavaScript
13% Other
6% JSON
2% TSX (tests)
<1% TSX

Generated lines of change

+ 302
- 117

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (5cbaa12) to head (cf62884).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5168   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          29       29           
  Lines        3366     3366           
  Branches     1396     1396           
=======================================
  Hits         3262     3262           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any issues with this, great work keeping important dependencies and tooling up to date!

Image of Ryan Lester <@buu700> Ryan Lester <@buu700>


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Keeping a linter up to date is always nice to have.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

@@ -4,25 +4,35 @@ const ModuleScopePlugin = require("react-dev-utils/ModuleScopePlugin");
module.exports = function override(config, env) {
config.resolve.alias["react-datepicker"] = path.resolve(__dirname, "..");
config.resolve.alias["react"] = path.resolve(__dirname, "node_modules/react");
//do stuff with the webpack config...

// Add raw-loader for specific example files
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comments.

◽ Compliment

Image of Ryan Lester <@buu700> Ryan Lester <@buu700>

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant