Fix types build by specifying return type on portal render method #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix solves the warning printed by rollup during build of types, which is preventing the generation of the portal.d.ts file. Specifycally, the TS error is the following: TS2742: The inferred type of render cannot be named without a reference to react-dom/ node_modules/@types/ react. This is likely not portable. A type annotation is necessary. Fixes Hacker0x01#5129
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@beawar you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5159 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 29 29
Lines 3350 3350
Branches 1405 1409 +4
=======================================
Hits 3246 3246
+ Misses 104 102 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This should effectively address the missing type declaration warning.
Reviewed with ❤️ by PullRequest
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5129
Problem
There is a warning printed by rollup during build of types, which is preventing the generation of the portal.d.ts file.
Specifically, the TS error is the following:
TS2742: The inferred type of render cannot be named without a reference to react-dom/ node_modules/@types/ react. This is likely not portable. A type annotation is necessary.
This warning is actually an error which is preventing the generation of the declaration file for the portal.tsx.
Changes
Added the return type to the render method of the portal class
Screenshots
To reviewers
Contribution checklist