-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to hide time caption #5100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@Qubitza you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 80
- 14
43% TSX
37% TSX (tests)
20% JavaScript
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it'll do what the description says. Thank you for adding a test and an example for this. I left one nit comment that you can treat as non-blocking. Nice job!
Reviewed with ❤️ by PullRequest
@@ -250,6 +252,27 @@ export default class Time extends Component<TimeProps, TimeState> { | |||
}); | |||
}; | |||
|
|||
renderTimeCaption = (): JSX.Element => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5100 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 29 29
Lines 3346 3350 +4
Branches 1408 1409 +1
=======================================
+ Hits 3242 3246 +4
Misses 102 102
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Description
Linked issue: #5099
Problem
It was previously not possible to completely hide the caption of the time picker.
Changes
Added
showTimeCaption
option toDatePicker
to hide the time caption.Added
Hide Time Caption
example to the docs.Added tests to check custom caption text and hidden state.
Screenshots
To reviewers
Contribution checklist