Fix #4934: ✅ Fix the broken test case in datepicker_test.test.js #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajis-qb
changed the title
balajis-qb
force-pushed
the
issue-4934/fix/datepicker-test-case
branch
from
088f817
to
5b660c7
Compare
…ing to the next month view when the current date is in the last row of the current month - Apply this fix as the render fails to rerender days to the next month view Closes Hacker0x01#4934
balajis-qb
force-pushed
the
issue-4934/fix/datepicker-test-case
branch
from
5b660c7
to
6efffd8
Compare
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4935 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 28 28
Lines 3264 3264
Branches 1343 1343
=======================================
Hits 3155 3155
Misses 109 109 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks like an easy enough change. I can see that a selected date was added.
Reviewed with ❤️ by PullRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4934
Pass the default date to the getOnInputKeyDownStuff to avoid switching to the next month view when the current date is in the last row of the current month
Contribution checklist