-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export ReactDatePickerCustomHeaderProps IF #4931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 2
- 0
100% TSX
Type of change
Minor Update - These changes appear to be a minor update to existing functionality and features.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 28 28
Lines 3264 3264
Branches 1343 1356 +13
=======================================
Hits 3155 3155
+ Misses 109 105 -4
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach should resolve the issue and seems okay to me. Alternatively, you could update places where you import ReactDatePickerCustomHeaderProps
to specify the /calendar
path.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Linked issue: closes #4906
Problem
See issue.
Changes
export ReactDatePickerCustomHeaderProps IF
Screenshots
To reviewers
Contribution checklist