Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert multiple_selected_dates.test.js into tsx #4827

Merged
merged 1 commit into from
May 28, 2024

Conversation

yasuaki640
Copy link
Contributor

@yasuaki640 yasuaki640 commented May 27, 2024


name: Migrate filter_times_test.test.js

Description

Linked issue: #4700

Changes
Converted multiple_selected_dates.test.js to a tsx file.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@martijnrusschen
Copy link
Member

Nice one, i've started the CI and your PR will be reviewed by the @PullRequestInc team.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (6491d16) to head (053cabb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4827   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          28       28           
  Lines        2977     2977           
  Branches     1285     1285           
=======================================
  Hits         2878     2878           
  Misses         99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yasuaki640 you can click here to see the review status or cancel the code review job - or - cancel by adding [!pr] to the title of the pull request.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 22
- 11

100% TSX (tests)

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and help improve the type safety of the multiple selected dates tests. No blocking issues or security concerns here. Thanks!

Image of Jonah Jonah


Reviewed with ❤️ by PullRequest

test/multiple_selected_dates.test.tsx Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me and matches the description

Image of Xiaoyong W Xiaoyong W


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit 17d3963 into Hacker0x01:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants