Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Fix typo of the name of the function getHightLightDaysMap w… #4808

Merged
merged 1 commit into from
May 22, 2024

Conversation

martijnrusschen
Copy link
Member

Fixing #4369 since files got converted to TS

…as corrected. (getHightLightDaysMap -> getHighLightDaysMap )
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 10
- 10

60% JavaScript (tests)
30% TSX
10% TypeScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (b0622ab) to head (84d568b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4808   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           6        6           
  Lines          61       61           
  Branches       19       19           
=======================================
  Hits           60       60           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; this is definitely a typo, as it makes no sense otherwise.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit ff3607c into main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant