Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add aria-label to read the day of the week instead of the shorthand #4693

Merged

Conversation

plahteenlahti
Copy link
Contributor

@plahteenlahti plahteenlahti commented Apr 15, 2024

Description

Linked issue: #3185

Problem

When using a screenreader it reads the days in the header as "Mo", "Tu"... etc. instead of the more understandable full name See the linked issue for a more detailed description

Changes

This PR adds aria-labels to the header dates so that the screenreader now reads days with full name e.g. "Monday" instead of "Mo"

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

@martijnrusschen
Copy link
Member

Can you make sure to add a test for this change?

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (4500100) to head (fd4c02e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4693      +/-   ##
==========================================
+ Coverage   97.00%   97.09%   +0.08%     
==========================================
  Files          28       28              
  Lines        2641     2653      +12     
  Branches     1119     1123       +4     
==========================================
+ Hits         2562     2576      +14     
+ Misses         79       77       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@plahteenlahti you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 32
- 0

97% JavaScript (tests)
3% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement for a subtle detail and looks good to me. Thanks for catching this and fixing it!

Image of Ryan Ryan


Reviewed with ❤️ by PullRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants