fix: #4400 Keyboard accessibility MonthYearPicker #4692
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@lasseklovstad you can click here to see the review status or cancel the code review job.
lasseklovstad
changed the title
There was a problem hiding this comment.
simlpe enough - this change seems to do that the descriptions says. Good job adding a test!
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
The change looks good to me and matches the description on MonthYearPicker, aka supporting Down/Up Arrow keys
Reviewed with ❤️ by PullRequest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4692 +/- ##
==========================================
+ Coverage 97.00% 97.08% +0.07%
==========================================
Files 28 28
Lines 2641 2644 +3
Branches 1119 1139 +20
==========================================
+ Hits 2562 2567 +5
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. |
Description
Linked issue: #4400
Problem
Focus calender month when the user presses down or up arrow keys in input field. This makes Datepicker accessible when only using keyboard.
Contribution checklist