fix: popper dosen't close if swapRange prop was passed #4689
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@mirus-ua you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4689 +/- ##
=======================================
Coverage 97.00% 97.00%
=======================================
Files 28 28
Lines 2638 2641 +3
Branches 1116 1136 +20
=======================================
+ Hits 2559 2562 +3
Misses 79 79 ☔ View full report in Codecov by Sentry. |
|
related PR #4654 |
There was a problem hiding this comment.
I believe these changes to be correct, but I question if the provided test already passes without the changes? It is not necessary to choose a different end date to exercise the new code?
Reviewed with ❤️ by PullRequest
The original code swaps the dates on the final check and doesn't provide a possibility of handling |
There was a problem hiding this comment.
I believe these changes to be correct, but I question if the provided test already passes without the changes? It is not necessary to choose a different end date to exercise the new code?
Reviewed with ❤️ by PullRequest
The original code swaps the dates on the final check and doesn't provide a possibility of handling
[null, endDate]state
https://github.com/Hacker0x01/react-datepicker/pull/4654/files#diff-ec767e14d91498b5b31a4ce826c4596061eb83a47d3dee00f6cbe1078232a75cR697
name: Fix input behavior
about: input doesn't close popper if swapRange prop passed
Problem
After the 6.7.0 release, I found that the new
swapRangefeature doesn't allow to close datepicker popper automatically when the range selected in reverse orderChanges
Add swapRange into the related check + a new test case
Screenshots
The first video is before the fix
2024-04-15.11.42.47.mov
The second one is after the fix
2024-04-15.11.44.25.mov
Contribution checklist