Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #3710 add yearClassName props #4634

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

yuki0410-dev
Copy link
Contributor

Description

Linked issue: close #3710

Problem
See issue #3710

Changes
add yearClassName props

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 56
- 18

65% JavaScript
31% JavaScript (tests)
4% Markdown

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (147c078) to head (ce488ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4634   +/-   ##
=======================================
  Coverage   96.96%   96.97%           
=======================================
  Files          28       28           
  Lines        2607     2608    +1     
  Branches     1101     1102    +1     
=======================================
+ Hits         2528     2529    +1     
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just one minor suggestion.

Image of Simon Simon


Reviewed with ❤️ by PullRequest

src/year.jsx Outdated Show resolved Hide resolved
@yuki0410-dev yuki0410-dev force-pushed the feat/3710 branch 2 times, most recently from 4e2cb6e to 3c675e0 Compare March 23, 2024 15:31
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4634 up until the latest commit (3c675e0). No further issues were found.

Reviewed by:

Image of Simon Simon

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem fine to me, I don't notice any issues.

Image of Ryan Ryan


Reviewed with ❤️ by PullRequest

test/year_picker_test.test.js Outdated Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4634 up until the latest commit (abbdcb6). No further issues were found.

Reviewed by:

Image of Ryan Ryan

src/year.jsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a yearClassName?
2 participants