Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4588 Allow time to be set via typing when minTime is set #4610

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

blanser-cc
Copy link
Contributor

@blanser-cc blanser-cc commented Mar 18, 2024

Description

Linked issue: close #4588

Problem
See issue #4588

Changes
Set the selected time to minTime only if no input to be kept is present.

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@blanser-cc you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 19
- 1

75% JavaScript (tests)
25% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, small PR. Thanks for adding tests!

Image of Simon Simon


Reviewed with ❤️ by PullRequest

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (7c81a78) to head (837f7f1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4610   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          28       28           
  Lines        2587     2589    +2     
  Branches     1089     1091    +2     
=======================================
+ Hits         2508     2510    +2     
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 09198c9 into Hacker0x01:main Mar 18, 2024
6 checks passed
@blanser-cc blanser-cc deleted the fix/4588 branch March 19, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time cannot be set via typing since v6.3.0
2 participants