fix: #4594 fix setSelected #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4602 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 28 28
Lines 2581 2583 +2
Branches 1077 1078 +1
=======================================
+ Hits 2501 2503 +2
Misses 80 80 ☔ View full report in Codecov by Sentry. |
src/index.jsx
Outdated
| @@ -697,7 +697,7 @@ export default class DatePicker extends React.Component { | |||
| if (noRanges) { | |||
| onChange([changedDate, null], event); | |||
| } else if (hasStartRange) { | |||
| if (isDateBefore(changedDate, startDate)) { | |||
| if (changedDate === null || isDateBefore(changedDate, startDate)) { | |||
|
Tests were added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: close #4594
Problem
See issue #4594
Changes
Added null check because passing null as the first argument of isBefore causes an error.
Screenshots
To reviewers
Contribution checklist