Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4581 and #4560 selected and preSelection with showWeekPicker #4601

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

yuki0410-dev
Copy link
Contributor

Description

Linked issue: close #4581,#4560
Problem
See issue #4581 and #4560

Changes
As per comment #4581, I have made the following changes to the showWeekPicker case.

  • Remove processing to correct date and preSelection to the first day of the week.
  • Changed the passing of date and preSelection from Month component to Week component so that they are corrected to the first day of the week before passing them to the Month component.

For #4560, a null selected was being passed to getStartOfWeek. This time, the processing timing of getStartOfWeek has been moved to Month, so that null is no longer included.

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 21
- 36

95% JavaScript
5% JavaScript (tests)

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (a044048) to head (b07608e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4601      +/-   ##
==========================================
+ Coverage   96.90%   96.94%   +0.03%     
==========================================
  Files          28       28              
  Lines        2583     2582       -1     
  Branches     1078     1081       +3     
==========================================
  Hits         2503     2503              
+ Misses         80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I see no issue here.

Image of Simon Simon


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit 8ef2eef into Hacker0x01:main Mar 16, 2024
6 checks passed
@yuki0410-dev yuki0410-dev deleted the fix/4581 branch March 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Week Picker Skips Months When Decreasing Month from 1st day falling after Fridays
2 participants