fix: enzyme to react testing library (3 test files) #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@asada-no4 you can click here to see the review status or cancel the code review job.
yuki0410-dev
reviewed
Mar 9, 2024
| @@ -2,12 +2,12 @@ import React from "react"; | |||
| import range from "lodash/range"; | |||
| import MonthDropdown from "../src/month_dropdown.jsx"; | |||
| import MonthDropdownOptions from "../src/month_dropdown_options.jsx"; | |||
| import { mount } from "enzyme"; | |||
| @@ -1,7 +1,6 @@ | |||
| import React from "react"; | |||
| import MonthYearDropdown from "../src/month_year_dropdown.jsx"; | |||
| import MonthYearDropdownOptions from "../src/month_year_dropdown_options.jsx"; | |||
| import { mount } from "enzyme"; | |||
asada-no4
force-pushed
the
feature/enzime-to-rtl
branch
from
01e04fc
to
0a55ae4
Compare
|
Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4571 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 28 28
Lines 2561 2561
Branches 1074 1074
=======================================
Hits 2481 2481
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests have been modified to migrate from enzime to the react testing library.
Details:.
Fixed tests to use rtl's render instead of enzime's mount where handleClickOutside is used.
Sorry if a similar modified PR has already been created.