Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4518: 🔨 Add accessibility props like role and aria-modal to the Calendar popup #4549

Conversation

balajis-qb
Copy link

Closes #4518

Description

This PR addresses the accessibility-related issues in the calendar component by adding props like role and aria-modal to it.

Reference Link

Changes Made

  • Updated CalendarContainer component with role="dialog" and aria-modal="true" props.
  • Added the corresponding test cases.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@balajis-qb you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 17
- 1

67% JavaScript (tests)
33% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (89249a5) to head (ac6daba).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4549      +/-   ##
==========================================
+ Coverage   95.45%   95.51%   +0.05%     
==========================================
  Files          29       29              
  Lines        2533     2566      +33     
  Branches     1039     1053      +14     
==========================================
+ Hits         2418     2451      +33     
  Misses        115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. I don't have any concerns with these changes.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit 705319a into Hacker0x01:main Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The calendar is missing accessibility properties
2 participants