Fix #4483: Enable onKeyDown handler for the month picker view and the year picker view #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2024 22:35
Used `handleOnMonthKeyDown` for MonthPicker component to handle Key down events as the `handleOnKeyDown` prop was linked with `handleOnDayKeyDown` (& passed to the Week component)
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@balajis-qb you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4533 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 29 29
Lines 2530 2533 +3
Branches 1037 1039 +2
=======================================
+ Hits 2415 2418 +3
Misses 115 115 ☔ View full report in Codecov by Sentry. |
test/month_test.test.js
Outdated
| onKeyDown={onKeyDownSpy} | ||
| />, | ||
| ); | ||
| TestUtils.Simulate.focus(ReactDOM.findDOMNode(datePicker.input)); |
There was a problem hiding this comment.
I believe this is deprecated behavior. Can you use the new RTL library?
test/month_test.test.js
Outdated
| ); | ||
| TestUtils.Simulate.focus(ReactDOM.findDOMNode(datePicker.input)); | ||
|
|
||
| const month = TestUtils.findRenderedDOMComponentWithClass( |
There was a problem hiding this comment.
Great start here. I don't have any further notes beyond the comments left by martijnrusschen.
Reviewed with ❤️ by PullRequest
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4483
Description
This PR addresses the missing event handling to handle the key-press event for the month picker and the year picker. For the Year Picker component, I added
onKeyDownand mapped it to the corresponding prop. However, the MonthPicker (month.jsx) is already receivingonKeyDownevent, but that was mapped to the handlerhandleOnDayKeyDownwhich is the handler specifically we're using onday.jsx. Inmonth.jsxwe're not directly using it, but passing that to theWeekcomponent. Hence for the month.jsx alone, I didn't change any of its current behavior, and I added a new prop namedhandleOnMonthKeyDownwhich is linked to theonKeyDownevent handler we pass from the DatePicker component. So users can still useonKeyDownitself for any datepicker view (day/month/year), but internallymonth.jsxalone is handling it viahandleOnMonthKeyDown.Changes Made
onKeyDownevent.