Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:enhance-code-syntax #4505

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix:enhance-code-syntax #4505

merged 1 commit into from
Feb 4, 2024

Conversation

mary139
Copy link

@mary139 mary139 commented Feb 4, 2024

This merge request includes two enhancements in syntax:

  1. onMonthChange and autoFocus have been used in the correct camelCase format throughout the project, except in the test file for react-datepicker. All other test titles follow this convention.

  2. isDayInRange has a similar issue in the comment within the index.js file.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@mary139 you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 4
- 4

75% JavaScript (tests)
25% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8493463) 95.39% compared to head (2b4f610) 95.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4505   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          29       29           
  Lines        2521     2521           
  Branches     1021     1021           
=======================================
  Hits         2405     2405           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 6bfd879 into Hacker0x01:main Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants