feature: Add day parameter to renderMonthContent function

[omarhoumz]

Need:

We are using the react-datepicker. We wanted to have custom logic depending on the day/year of the month.

Change:

I added the day info when rendering the custom month content in the renderMonthContent prop.

Docs:

I added the day prop in the docs example as well to reflect the change.

Tests:

In this test file: test/month_test.test.js, there is a test for renderMonthContent.

[pullrequest]

✅ This pull request was sent to the PullRequest network.

---

@omarhoumz you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 18
- 11

52% JavaScript
48% JavaScript (tests)

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fbd62e) 95.32% compared to head (7105690) 95.28%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4405      +/-   ##
==========================================
- Coverage   95.32%   95.28%   -0.05%     
==========================================
  Files          28       28              
  Lines        2479     2479              
  Branches     1020     1020              
==========================================
- Hits         2363     2362       -1     
- Misses        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pullrequest]

This appears reasonable, I assume the day argument will be leveraged in a future PR, or is there for users to add their own custom functionality?

Will B

---

Reviewed with ❤️ by PullRequest

[pullrequest]

This is looking like a great start, but the test doesn't assert that the day is passed though properly.

Graham C

---

Reviewed with ❤️ by PullRequest

[omarhoumz]

This appears reasonable, I assume the day argument will be leveraged in a future PR, or is there for users to add their own custom functionality?

Will B

Reviewed with ❤️ by PullRequest

It's their for users to add their own functionality.

[omarhoumz]

This is looking like a great start, but the test doesn't assert that the day is passed though properly.

Graham C

Reviewed with ❤️ by PullRequest

There wasn't any assertion for the other arguments either. I'll add an assertion for day

[omarhoumz]

This is looking like a great start, but the test doesn't assert that the day is passed though properly.
Graham C
Reviewed with ❤️ by PullRequest

There wasn't any assertion for the other arguments either. I'll add an assertion for day

Added assertion for day

[pullrequest]

I have just one more minor note left inline for your consideration.

Graham C

---

Reviewed with ❤️ by PullRequest

[pullrequest]

Great. I don't have any further feedback here. 🎉

Graham C

---

Reviewed with ❤️ by PullRequest

[omarhoumz]

Great. I don't have any further feedback here. 🎉

Graham C

Reviewed with ❤️ by PullRequest

How can we move forward with the PR?

[pullrequest]

Great. I don't have any further feedback here. 🎉

Reviewed with ❤️ by PullRequest

How can we move forward with the PR?

The next step is for the maintainers on GitHub .

Graham C

[omarhoumz]

@martijnrusschen Any chance we can check this change? It has been reviewed by Graham & Will

[pullrequest]

PullRequest reviewed the updates made to #4405 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Graham C

[omarhoumz]

@martijnrusschen Thanks for merging the change. Can I ask how is the release process done?