refactor: change 'var' to 'let' and 'const' #4379
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@Sauter001 you can click here to see the review status or cancel the code review job.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4379 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 27 27
Lines 2374 2374
Branches 966 968 +2
=======================================
Hits 2295 2295
Misses 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This looks great to me. Switching away from var is definitely helpful.
I do think var still exists in the codebase, and the PR description made me think this was covering all of them, but I assume the others will be in separate PRs.
Reviewed with ❤️ by PullRequest
| * @param {date} start | ||
| * @param {date} end | ||
| * @param {Date} start | ||
| * @param {Date} end |
There was a problem hiding this comment.
These minor refactorings look good—I don't see any issues here.
Reviewed with ❤️ by PullRequest
Updated:
vardeclarations changed toconstorletto be clear@param {date}description to@param {Date}