Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date_utils): fixing navigation on yearpicker #2230

Merged

Conversation

hillterence007
Copy link
Contributor

When using the yearpicker the navigation is disappearing while clicking on next. The user can´t get to the initial state.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2230 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   91.98%   92.09%   +0.10%     
==========================================
  Files          20       20              
  Lines        1223     1252      +29     
  Branches      312      330      +18     
==========================================
+ Hits         1125     1153      +28     
  Misses         40       40              
- Partials       58       59       +1     
Impacted Files Coverage Δ
src/date_utils.js 99.10% <100.00%> (ø)
src/week.jsx 86.95% <0.00%> (ø)
src/month.jsx 94.04% <0.00%> (ø)
src/calendar.jsx 93.67% <0.00%> (ø)
src/day.jsx 92.78% <0.00%> (+0.31%) ⬆️
src/index.jsx 87.54% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e59bb0...a558e52. Read the comment docs.

@martijnrusschen
Copy link
Member

Thanks, can you add a test to make sure we don't break this in the future?

@hillterence007
Copy link
Contributor Author

Thanks, can you add a test to make sure we don't break this in the future?

Done

@martijnrusschen martijnrusschen merged commit 06ee1de into Hacker0x01:master Jul 16, 2020
@saswat3115
Copy link

Is this fix publidhed to npm ? I dont see this changes in version 3.1.3 @hillterence007 @martijnrusschen

p-rogas pushed a commit to p-rogas/react-datepicker that referenced this pull request Mar 22, 2023
* fix(date_utils): fixing navigation on yearpicker

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants