Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week number is highlighted when selecting the first day of the week #4489

Closed
MaertHaekkinen opened this issue Jan 31, 2024 · 1 comment · Fixed by #4608
Closed

Week number is highlighted when selecting the first day of the week #4489

MaertHaekkinen opened this issue Jan 31, 2024 · 1 comment · Fixed by #4608

Comments

@MaertHaekkinen
Copy link

MaertHaekkinen commented Jan 31, 2024 •
edited
Loading

Describe the bug
Week number gets highlighted when selecting the first day of the week, but not when selecting any other day of the week.

To Reproduce

  1. Click on the first day of the week.
    image

  2. Click on any other day of the week (same or other)
    image

Expected behavior
Week number gets highlighted for both cases or only when a range is selected - I am not 100% sure on what is the agreed behaviour, but current one seemed very odd to me.

Desktop

  • OS: Windows 10
  • Browser: Chrome
  • Version: 121.0.6167.139 (Official Build) (64-bit)

Where to test?

Codepen:
https://codepen.io/MaertHaekkinen/pen/ExMQrMq

OR

https://reactdatepicker.com/ - "Display Week Numbers"
@MaertHaekkinen MaertHaekkinen changed the title Week number gets highlighted when selecting the first day of the week Week number is highlighted when selecting the first day of the week Jan 31, 2024
@Vedant767
Copy link

Hi, I will take this issue.

yuki0410-dev added a commit to yuki0410-dev/react-datepicker that referenced this issue Mar 17, 2024
@yuki0410-dev
fix: Hacker0x01#4489 Disable weekNumber highlighting when no click ha…
6fc6b3f 
…ndler is assigned.
@yuki0410-dev yuki0410-dev mentioned this issue Mar 17, 2024
Merged
3 tasks
yuki0410-dev added a commit to yuki0410-dev/react-datepicker that referenced this issue Mar 17, 2024
@yuki0410-dev
fix: Hacker0x01#4489 Disable weekNumber highlighting when no click ha…
7776ddd 
…ndler is assigned.
yuki0410-dev added a commit to yuki0410-dev/react-datepicker that referenced this issue Mar 18, 2024
@yuki0410-dev
fix: Hacker0x01#4489 Disable weekNumber highlighting when no click ha…
740007b 
…ndler is assigned.
martijnrusschen added a commit that referenced this issue Mar 18, 2024
@martijnrusschen
Merge pull request #4608 from yuki0410-dev/fix/4489
7c81a78 
fix: #4489 Disable weekNumber highlighting when no click handler is assigned.
@IrvingYHM IrvingYHM mentioned this issue Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MaertHaekkinen @Vedant767