Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard accessibility of Shift+PageUp and Shift+PageDown not aligned with ARIA authoring practices guide #4456

Closed
balajis-qb opened this issue Jan 16, 2024 · 0 comments · Fixed by #4457 or qburst/react-datepicker-3#12
Closed

Keyboard accessibility of Shift+PageUp and Shift+PageDown not aligned with ARIA authoring practices guide #4456

balajis-qb opened this issue Jan 16, 2024 · 0 comments · Fixed by #4457 or qburst/react-datepicker-3#12

Comments

@balajis-qb
Copy link

Describe the bug
Shift+PageUp and Shift+PageDown keyboard shortcuts are not aligned with the W3C WAI-ARIA. Currently, Shift+PageUp is doing the same as the PageUp shortcut functionality and Shift+PageDown is doing the same as the PageDown shortcut functionality.

Date Picker Pattern

image

To Reproduce
Steps to reproduce the behavior:

  1. Open the calendar
  2. Move the focus to the calendar
  3. Press Shift + PageUp or Shift + PageDown

Expected behavior

  • Shift + PageUp should change the grid of dates to the same month in the previous year.
  • Shift + PageDown should change the grid of dates to the same month in the next year.
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Jan 16, 2024
feature: 🔨 Add ARIA accessibility for shift+pageUp and shift+pageDown…
c62fc43 
… key

Add shift+pageUp and shift+pageDown handlers aligned with W3C WAI-ARIA principles.  Previously navigation moves to the previous month and the next month instead of moving to one year before and after.  After this change, it's moving to [the previous and the next year](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/)

Closes Hacker0x01#4456
This was referenced Jan 16, 2024
Merged
Merged
martijnrusschen added a commit that referenced this issue Jan 16, 2024
@martijnrusschen
Merge pull request #4457 from qburst/issue-4456/fix/aria-shift-pageUp…
e855d4b 
…-and-shift-pageDown

Fix #4456: Add shift+pageUp key and shift+pageDown key navigation in Calendar component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@balajis-qb