-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calendarStartDay and showWeekPicker, selected week is not active #4455
Comments
yuki0410-dev
added a commit
to yuki0410-dev/react-datepicker
that referenced
this issue
Mar 18, 2024
3 tasks
yuki0410-dev
added a commit
to yuki0410-dev/react-datepicker
that referenced
this issue
Mar 18, 2024
yuki0410-dev
added a commit
to yuki0410-dev/react-datepicker
that referenced
this issue
Mar 18, 2024
martijnrusschen
added a commit
that referenced
this issue
Mar 19, 2024
fix: #4455 Pass calendarStartDay props from week to day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A clear and concise description of what the bug is.
When showWeekPicker is set true and calendarStartDay is set to 1, then only the first day of the week gets active state.
If calendarStartDay prop is removed it works as intended.
To Reproduce
Steps to reproduce the behavior:
<DatePicker selected={date} startDate={x} onChange={setDate} showWeekPicker={true} />
<DatePicker calendarStartDay={1} selected={x} startDate={x} onChange={setX} showWeekPicker={true} />
Expected behavior
A clear and concise description of what you expected to happen.
selected week should be in active state
Screenshots
![Screenshot 2024-01-14 at 23 53 56](https://private-user-images.githubusercontent.com/5435960/296618905-40cbe8f7-a30a-4b74-8c69-32506bc20480.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODc2NzYsIm5iZiI6MTczOTE4NzM3NiwicGF0aCI6Ii81NDM1OTYwLzI5NjYxODkwNS00MGNiZThmNy1hMzBhLTRiNzQtOGM2OS0zMjUwNmJjMjA0ODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTEzNjE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTc5MTAzNjg0MzNjOTcwNDNjMTA4NzJlNDk0NzQyZTQ3MGEyMzBiZGViMjBiYTA5YzdmMjFjMmVlYjg1MzVhNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.T4dRw4H46CWcvqFJFF_PstKmILOcOKWn9GKy5XI980k)
![Screenshot 2024-01-14 at 23 54 21](https://private-user-images.githubusercontent.com/5435960/296618906-eaa784b5-a78d-4551-a0f9-bbb1a79ef13b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODc2NzYsIm5iZiI6MTczOTE4NzM3NiwicGF0aCI6Ii81NDM1OTYwLzI5NjYxODkwNi1lYWE3ODRiNS1hNzhkLTQ1NTEtYTBmOS1iYmIxYTc5ZWYxM2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTEzNjE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODMzZjEyZDczOWE1MmFhY2M0M2RhMmM3N2IzOTFlMDlmZDI5MjQzYThiYjE2MzFhNDBhNTdhOWYxNmRlZjZhOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.lbwVbfUihKxuroIuXK-v6UggwZA4-wzPDv8IiO2ZtdI)
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: