Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard accessibility not aligned with ARIA authoring practices guide #4420

Closed
barettjfed opened this issue Dec 22, 2023 · 0 comments · Fixed by #4430 or qburst/react-datepicker-3#10
Closed

Keyboard accessibility not aligned with ARIA authoring practices guide #4420

barettjfed opened this issue Dec 22, 2023 · 0 comments · Fixed by #4430 or qburst/react-datepicker-3#10

Comments

@barettjfed
Copy link
Contributor

Describe the bug
Some of the keyboard shortcuts are not aligned to what the W3C WAI-ARIA.
Date Picker Pattern
Like the Home and End button should go to the first and last day of the week.

To Reproduce
Steps to reproduce the behavior:

  1. Open the calendar
  2. Press Home on keyboard
  3. Previous year is selected

Expected behavior
Should move the selected day to the first day of the week.
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Jan 2, 2024
fix: Update home key and end key navigation in Calendar component
27e8c4b 
Adjust home and end handlers to align with W3C WAI-ARIA principles.  Previously navigation moves to the first and last day of the week instead of one year before and after the calendar.  After this change it's moving to the first and last day of the week

Closes Hacker0x01#4420
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Jan 2, 2024
fix: Update home key and end key navigation in Calendar component
0f81088 
Adjust home and end handlers to align with W3C WAI-ARIA principles.  Previously navigation moves to the first and last day of the week instead of one year before and after the calendar.  After this change it's moving to [the first and last day of the week](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/)

Reference Link:

Closes Hacker0x01#4420
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Jan 2, 2024
fix: Update home key and end key navigation in Calendar component
62807cf 
Adjust home and end handlers to align with W3C WAI-ARIA principles.  Previously navigation moves to the first and last day of the week instead of one year before and after the calendar.  After this change it's moving to [the first and last day of the week](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/)

Closes Hacker0x01#4420
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Jan 2, 2024
fix: Update home key and end key navigation in Calendar component
664df9f 
Adjust home and end handlers to align with W3C WAI-ARIA principles.  Previously navigation moves to the first and last day of the week instead of one year before and after the calendar.  After this change, it's moving to [the first and last day of the week](https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/)

Closes Hacker0x01#4420
This was referenced Jan 2, 2024
Merged
Merged
martijnrusschen added a commit that referenced this issue Jan 3, 2024
@martijnrusschen
Merge pull request #4430 from qburst/issue-4420/fix/aria-home-and-end…
1be1893 
…-key

Fix #4420: Update home key and end key navigation in Calendar component
@balajis-qb balajis-qb mentioned this issue Jan 3, 2024
Closed
@balajis-qb balajis-qb mentioned this issue Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@barettjfed