Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation is disabled if minDate or maxDate are null #4011

Closed
KevinFabre-ods opened this issue Apr 26, 2023 · 0 comments · Fixed by qburst/react-datepicker-3#22 or #4848
Closed

Comments

@KevinFabre-ods
Copy link
Contributor

Describe the bug
If minDate or maxDate have a value of null keyboard navigation thought days is disabled.

To Reproduce
Steps to reproduce the behavior:

render:

<ReactDatePicker 
   minDate={null} 
   maxDate={null}
/>

Expected behavior
Keyboard navigation should be enabled.

Desktop

Any OS or browser

Additional context
I ran into this issue because @types/react-datepicker defined type for minDate and maxDate as Date | null | undefined.
type for minTime and maxTime is Date | undefined.

I can make the edit on @types/react-datepicker, could you please confirm that the types for minDate and maxDate should be Date | undefined ?

balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue May 31, 2024
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue May 31, 2024
martijnrusschen added a commit that referenced this issue May 31, 2024
…te-maxDate-onKeyDown

Fix #4011: 🐛 Handle Arrow Navigation on calendar days even when the minDate/maxDate is nul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment