Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to FloatingUI #3842

Closed
jakubpodolski opened this issue Dec 1, 2022 · 2 comments · Fixed by #4393
Closed

Migration to FloatingUI #3842

jakubpodolski opened this issue Dec 1, 2022 · 2 comments · Fixed by #4393

Comments

@jakubpodolski
Copy link

jakubpodolski commented Dec 1, 2022

According to this discussion, popperjs/core has been rebranded as FlotingUI. The previous version will be kept in a low maintenance mode, as the new library @floating-ui/popper takes its place.

Are there any plans to migrate internal mechanisms so that they utilize this new library?

@Xiphe
Copy link

Xiphe commented Jun 14, 2023

Agree that it would be awesome if react-datepicker would migrate to floating-ui.

In our design system we're already using floating-ui for a lot of other tasks and it would be awesome if we wouldn't load multiple positioning libraries at the same time.

I can start working on a PR for this given there's interest from the maintainers.

@martijnrusschen
Copy link
Member

Feel free to make a PR to migrate.

G07cha added a commit to G07cha/react-datepicker that referenced this issue Nov 26, 2023
G07cha added a commit to G07cha/react-datepicker that referenced this issue Nov 26, 2023
Breaking changes:

- `popperModifiers` only accepts [Floating-UI specific middleware](https://floating-ui.com/docs/middleware)
- 'auto', 'auto-start', and 'auto-end' placements are no longer supported
- `popperProps` only accept [`useFloating` options](https://floating-ui.com/docs/usefloating#options)

Closes Hacker0x01#3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants