Cron #60

barrucadu · 2014-05-23T21:17:07Z

cron.

(cron)

…ff events with a time delta

…events

…inCron::at and PluginCron::every

… from the same plugin are registered

…hey were scheduled to be called at.

…name and some args to call it with when the time is up, and there is just one repeating task (the scheduler) which handles everything. This is to allow saving things to the database, although that isn't done yet.

…ison is restarted

… been fired off.

… named method change)

… allow tasks which themselves schedule other tasks

alanbriolat · 2014-06-10T09:24:59Z

csbot/plugins/cron.py

+            # shouldn't get this far anyway, killing the bot is worse.
+            try:
+                func(taskdef['time'], *taskdef['args'], **taskdef['kwargs'])
+            except:


This should be except Exception: - just using except: will catch everything, including important signals like KeyboardInterrupt (which the Twisted reactor handles to shutdown gracefully). except Exception as e: would even give you the exception instead of having to poke sys.exc_info().

alanbriolat · 2014-06-10T11:39:57Z

I wonder if the task definition could be restructured somewhat to remove some duplication of information?

key	description
owner	name of plugin that created the task
name	name of the task (shouldn't contain owner)
when	datetime to trigger the task at
interval	(optional) reschedule at `when + interval` when task is triggered, if absent/None task does not repeat
callback	(optional) call `owner.callback(args, kwargs)` when task triggers, if absent/None use `owner.name(args, **kwargs)`
args	(optional) callback positional arguments
kwargs	(optional) callback keyword arguments

Are there cases you were considering where you might want a task name not tied to a plugin name, or triggering callbacks on other plugins?

barrucadu added 30 commits April 11, 2014 16:45

Initial implementation of a cron plugin: supports scheduling of one-o…

6eb6eaf

…ff events with a time delta

Add scheduleAt method to cron, to allow scheduling by datetimes

65e5312

Initial implementation of regular events

6b98700

Everything is running in Twisted's thread now, so no need for locks

a7248c6

Better handling of exceptions in cron callbacks

9431443

Improve documentation

1447810

Fix starting of regular events (albeit in an ugly way)

b8388f9

Simplify plugin interface to cron: restrict it to just that plugin's …

c78b70d

…events

Remove Cron::scheduleAt

4c670d2

Unify Cron::schedule and Cron::scheduleEvery

663780c

Fix Cron::setup to use schedule instead of scheduleAt

e37fc1a

Rename PluginCron::schedule to PluginCron::after, to fit in with Plug…

ed345a1

…inCron::at and PluginCron::every

Raise an exception in Cron::schedule if two events with the same name…

ba1fae6

… from the same plugin are registered

Make Cron plugin-agnostic, and handle the name-mangling in PluginCron

3eac061

Prettify Cron::setup_regular a bit

653ab4f

The argument to the DuplicateNameException is now just the name

cbc0a9f

Callbacks passed to Cron::schedule now get passed the time at which t…

3db9c7d

…hey were scheduled to be called at.

Don't print out the callback in a Cron::_runcb error log

f12cfb5

Fix computation of when in Cron::setup

74bb2c7

Integrate cron with mongodb so tasks get saved and restored when Math…

9a446fb

…ison is restarted

Gracefully handle tasks referring to bad plugin or method names

4780134

Don't save cron.hourly/daily/weekly to database, as per the comment

b4bd822

Store all tasks in the database, and only remove them when a task has…

a55c503

… been fired off.

Update documentation

67eddd0

More comments, and shuffle around the scheduler slightly

43a2efd

More comments explaining the scheduler

2cd526c

Fix a documentation typo

94d8aca

Make regular events actually work (bug resulting from the callback to…

d376f07

… named method change)

Replace the six self.tasks.remove calls with one regex removal

9e97ecc

barrucadu added 5 commits April 14, 2014 17:12

Add in a missing repeating=True (NOW regular events should work)

08dcbf6

Actually store task names (this is why I should test things)

78816c9

Move removing/rescheduling tasks to the top of the scheduler loop, to…

e56d8bc

… allow tasks which themselves schedule other tasks

Use a raw string literal for the tasks.remove regex

04a155d

That shouldn't have been in quotes…

5fcd5c9

alanbriolat reviewed Jun 10, 2014
View reviewed changes

barrucadu added 4 commits June 10, 2014 12:53

In event_runner, only catch Exception, and don't use sys.exc_info()

430687d

Catch an AttributeError in event_runner on missing methods

23ea83f

Remove self.plugins, use self.bot.plugins

ad7793c

Simplify task definition

2aefb06

alanbriolat merged commit 2aefb06 into HackSoc:master Jun 11, 2014

barrucadu deleted the cron branch June 11, 2014 23:15

alanbriolat mentioned this pull request Jun 18, 2014

Topic feature #33

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cron #60

Cron #60

barrucadu commented May 23, 2014

alanbriolat Jun 10, 2014

alanbriolat commented Jun 10, 2014

Cron #60

Cron #60

Conversation

barrucadu commented May 23, 2014

alanbriolat Jun 10, 2014

Choose a reason for hiding this comment

alanbriolat commented Jun 10, 2014