Port delayed sampling to habana_main #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of: #834 which should fix TP>1 issues. --------- Co-authored-by: Tianmu Li <[email protected]>
madamczyk-intel
requested review from
afierka-intel,
kzawora-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
michalkuligowski
approved these changes
Mar 6, 2025
michalkuligowski
left a comment
michalkuligowski
left a comment
There was a problem hiding this comment.
We need to plan dividing execute_model into smaller specialized methods in the future (it has more than 300 lines :D)
Closed
yangulei
pushed a commit
to yangulei/vllm-fork
that referenced
this pull request
Mar 11, 2025
ranzhejiang
pushed a commit
to ranzhejiang/vllm-fork
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Michal Adamczyk <[email protected]>
ranzhejiang
pushed a commit
to ranzhejiang/vllm-fork
that referenced
this pull request
Apr 8, 2025
Co-authored-by: Michal Adamczyk <[email protected]>
michalkuligowski
pushed a commit
that referenced
this pull request
Apr 8, 2025
This restores callback calling order from before #849 was merged . This reduces host overhead between decodes when neither MSS nor delayed sampling are enabled.
madamczyk-intel
added a commit
that referenced
this pull request
Apr 8, 2025
This restores callback calling order from before #849 was merged . This reduces host overhead between decodes when neither MSS nor delayed sampling are enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.