Refactor long-context + LoRA flow#807
Merged
vivekgoe merged 2 commits intohabana_mainfrom Feb 11, 2025
Merged
Conversation
scsudhak-intel
requested review from
afierka-intel,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz,
michalkuligowski and
vivekgoe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors long-context + LoRA flow to align with the upstream main branch vllm-project#12812.
HPU requires special handling while creating
long_lora_offsets_tensorinconvert_mapping. (refer)As suggested by the vllm team this PR sets
long_lora_contextto None while callingconvert_mapping. This avoids HPU specific conditions insideconvert_mappingand explicitly handles HPU long-lora logic inside overrided_update_base_metadata.