Skip to content

Disable mark scales as const & add dist.barrier only for multiple cards #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Disable mark scales as const & add dist.barrier only for multiple cards #1091

wants to merge 17 commits into from

Conversation

@yiliu30
Copy link

@yiliu30 yiliu30 commented Apr 15, 2025

xuechendi and others added 17 commits April 8, 2025 17:02
@xuechendi
apply deepseek change
236ac10 
Signed-off-by: Chendi.Xue <[email protected]>
@xuechendi
update for mypy
d273848 
Signed-off-by: Chendi.Xue <[email protected]>
@xuechendi
fix acc issue
7cf1dcf 
Signed-off-by: Chendi.Xue <[email protected]>
@xuechendi
fix mypy
4560a09 
Signed-off-by: Chendi.Xue <[email protected]>
@xuechendi
update vllm-hpu-extension comit id for test
85f0693 
Signed-off-by: Chendi.Xue <[email protected]>
@kwisniewski98
Add temporary workaround for V1
a93c26a 
Signed-off-by: kwisniewski98 <[email protected]>
@xuechendi
Resolve review comments
496938d 
Signed-off-by: Chendi Xue <[email protected]>
@xuechendi
update dependent vllm-hpu-extension
a6358a5 
Signed-off-by: Chendi Xue <[email protected]>
@xuechendi
Merge branch 'v1.21.0_next' into dev/chendi/deepseek_r1
d362dd4
@kwisniewski98
Remove o_proj only for deepseek
b49caca 
Signed-off-by: kwisniewski98 <[email protected]>
@kwisniewski98
Change vllm-hpu-extension version
214bcae 
Signed-off-by: kwisniewski98 <[email protected]>
@kwisniewski98
Merge branch 'v1.21.0_next' into dev/chendi/deepseek_r1
3cb8b06
@kwisniewski98
Explicitly disable t.compile for deepseek
9b85748 
Signed-off-by: kwisniewski98 <[email protected]>
@kwisniewski98
Change method of checking lazy mode
1d7fb51 
Signed-off-by: kwisniewski98 <[email protected]>
@Yi4Liu
add flag to disable mark scales as const
e99def7 
Signed-off-by: Yi Liu <[email protected]>
@Yi4Liu
call barrier if needed
5539451 
Signed-off-by: Yi Liu <[email protected]>
@Yi4Liu
fix typo
0e515d2 
Signed-off-by: Yi Liu <[email protected]>
@yiliu30 yiliu30 requested review from nirda7 and xuechendi April 15, 2025 14:46
@xuechendi xuechendi changed the base branch from dev/chendi/deepseek_r1 to v1.21.0_next April 15, 2025 15:00
xuechendi
xuechendi approved these changes Apr 15, 2025
View reviewed changes
Copy link

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiliu30
Copy link
Author

yiliu30 commented Apr 16, 2025

Close it, and switch to #1100.

@yiliu30 yiliu30 closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuechendi xuechendi xuechendi approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@nirda7 nirda7 Awaiting requested review from nirda7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yiliu30 @xuechendi @kwisniewski98 @Yi4Liu