Enable Falcon FP8 inference#94
Merged
Merged
Conversation
schoi-habana
requested review from
bhargaveede,
libinta,
mandy-li,
ssarkar2 and
vivekgoe
as code owners
mandy-li
reviewed
Mar 7, 2024
vivekgoe
reviewed
Mar 8, 2024
vivekgoe
left a comment
vivekgoe
left a comment
There was a problem hiding this comment.
@schoi-habana since the changes in modeling_falcon.py are large it is difficult to go over each of them. I would suggest you to request QA to check Falcon-40B & Falcon-180B fine-tuning with this PR to avoid any degrades.
Another generic comment, for the model classes you are overriding, please add in comment which transformer commit these are derived from and list the differences from that base commit. This will be useful when model is rebased to new transformer versions in future.
schoi-habana
force-pushed
the
schoi/falcon_180b_quant_PR
branch
from
deb2e75 to
c852094
Compare
schoi-habana
force-pushed
the
schoi/falcon_180b_quant_PR
branch
from
c852094 to
af025a7
Compare
|
@libinta , since your team worked on Falcon-40B FT enablement, please review the code and test Falcon-40B FT as well. Thanks |
mandy-li
requested changes
Mar 11, 2024
schoi-habana
force-pushed
the
schoi/falcon_180b_quant_PR
branch
from
ecac5fa to
7b9852a
Compare
mandy-li
approved these changes
Mar 13, 2024
schoi-habana
pushed a commit
that referenced
this pull request
Mar 19, 2024
squash of the following 5 commits enable Falcon FP8 inference added example command in readme, code cleanup resolve issues in finetuning enable non reuse cache flow for fp8 revert non reuse_cache flow for training due to perf drop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
falcon-7b, falcon-40b, falcon-180b quantization enabled with --reuse_cache
Before submitting