Fix tests (#669)#41
Merged
Merged
Conversation
Author
|
@ssarkar2 I have brought your commit to fork. Please review |
vivekgoe
approved these changes
Feb 15, 2024
astachowiczhabana
added a commit
that referenced
this pull request
Nov 29, 2024
PR huggingface#1358 from upstream introduced a nested for loop which caused performance drop observed in T5 summarization. This commit translates the loop into tensor operations and restores performance. Co-authored-by: Adam Stachowicz <105052242+astachowiczhabana@users.noreply.github.com>
ugolowic
added a commit
that referenced
this pull request
Dec 3, 2024
PR huggingface#1358 from upstream introduced a nested for loop which caused performance drop observed in T5 summarization. This commit translates the loop into tensor operations and restores performance. Co-authored-by: Adam Stachowicz <105052242+astachowiczhabana@users.noreply.github.com> Signed-off-by: Urszula Golowicz <urszula.golowicz@intel.com>
xinyu-intel
pushed a commit
that referenced
this pull request
Mar 4, 2025
PR huggingface#1358 from upstream introduced a nested for loop which caused performance drop observed in T5 summarization. This commit translates the loop into tensor operations and restores performance. Co-authored-by: Adam Stachowicz <105052242+astachowiczhabana@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting