[Bridgetower] Fix for Nonetype in image#39
Closed
MohitIntel wants to merge 3 commits into
Closed
Conversation
MohitIntel
requested review from
bhargaveede,
libinta,
mandy-li,
ssarkar2 and
vivekgoe
as code owners
vivekgoe
suggested changes
Feb 14, 2024
vivekgoe
left a comment
vivekgoe
left a comment
There was a problem hiding this comment.
Please remove JIRA Id from commit message. Reason for this request is that when migrating PRs from OH-fork to OH main we want to make minimal changes (specially to commit message) and also avoid exposing habana internal information.
murthy-l-habana
requested changes
Feb 14, 2024
murthy-l-habana
left a comment
murthy-l-habana
left a comment
There was a problem hiding this comment.
Again, as mentioned in JIRA, this API is not exposed to user and should not be used for custom ops addition. Please use user level API only.
libinta
approved these changes
Feb 14, 2024
libinta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [SW-174850] Nonetype error in image.
Before submitting