Skip to content

Revert "[SW-185803] Enable FusedSDPA fp8 in Llama FT (#291)"#295

Merged
oabramovich merged 1 commit into
habana-mainfrom
dev/egeva/revert_sdpa
Jul 15, 2024
Merged

Revert "[SW-185803] Enable FusedSDPA fp8 in Llama FT (#291)"#295
oabramovich merged 1 commit into
habana-mainfrom
dev/egeva/revert_sdpa

Conversation

@MrGeva
Copy link
Copy Markdown

@MrGeva MrGeva commented Jul 14, 2024

This reverts commit 35f6fbe.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@MrGeva MrGeva requested a review from a user July 14, 2024 16:59
@vivekgoe
Copy link
Copy Markdown

vivekgoe commented Jul 15, 2024

@MrGeva Can you please share JIRA or some other description about the issue this commit is causing? Will approve revert immediately if there is no quick fix available. Thanks. FYI @pbielak @wszczurekhabana

Copy link
Copy Markdown

@dudilester dudilester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Copy Markdown

@vivekgoe vivekgoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dudilester @MrGeva Please share reason for revert before merging revert.

@MrGeva
Copy link
Copy Markdown
Author

MrGeva commented Jul 15, 2024

@MrGeva Can you please share JIRA or some other description about the issue this commit is causing? Will approve revert immediately if there is no quick fix available. Thanks. FYI @pbielak @wszczurekhabana

https://jira.habana-labs.com/browse/SW-192667

@wszczurekhabana
Copy link
Copy Markdown

@MrGeva @vivekgoe let's revert. We are working out the reason of failure on inference code path.

@oabramovich oabramovich dismissed vivekgoe’s stale review July 15, 2024 09:11

this is blocking all promotions, must revert ASAP

@oabramovich oabramovich merged commit ac42d0a into habana-main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants