FP8 FusedSDPA support for Mistral#195
Merged
Merged
Conversation
jiminha
requested review from
bhargaveede,
hlahkar,
libinta,
mandy-li,
ssarkar2 and
vivekgoe
as code owners
libinta
approved these changes
May 9, 2024
libinta
approved these changes
May 9, 2024
astachowiczhabana
pushed a commit
that referenced
this pull request
May 13, 2024
astachowiczhabana
pushed a commit
that referenced
this pull request
Mar 13, 2025
Change-Id: Ic15cd7d04b93a4674425f4752ef31eedb64afe87
astachowiczhabana
pushed a commit
that referenced
this pull request
Mar 31, 2025
Change-Id: Ic15cd7d04b93a4674425f4752ef31eedb64afe87
zhanglirong1999
pushed a commit
that referenced
this pull request
Apr 17, 2025
Change-Id: Ic15cd7d04b93a4674425f4752ef31eedb64afe87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently FusedSDPA with fp8 with 32k has accuracy issue though. 16k is fine.