Skip to content

Add support for safetensors when reading checkpoints #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tjs-intel wants to merge 1 commit into from
Closed

Add support for safetensors when reading checkpoints #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion optimum/habana/checkpoint_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def get_checkpoint_files(model_name_or_path, local_rank, token=None):

# Extensions: .bin | .pt
# Creates a list of paths from all downloaded files in cache dir
file_list = [str(entry) for entry in Path(cached_repo_dir).rglob("*.[bp][it][n]") if entry.is_file()]
path = Path(cached_repo_dir)
globs = ["*.bin", "*.pt", "*.safetensors"]
Copy link
Copy Markdown

@puneeshkhanna puneeshkhanna Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need some kind of if else check ; cached repo dir can have both .safetensors and .pt files.

Copy link
Copy Markdown
Author

@tjs-intel tjs-intel Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code that is already there loads .bin and .pt files, can the cached repo have both of those as well? I might be misunderstanding something

Copy link
Copy Markdown

@puneeshkhanna puneeshkhanna Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can have both.

file_list = [str(entry) for glob in globs for entry in Path(cached_repo_dir).rglob(glob) if entry.is_file()]
return file_list


Expand Down