Downgrade pytest in language modelling#178
Merged
astachowiczhabana merged 1 commit intoMay 7, 2024
Merged
Conversation
Author
libinta
reviewed
Apr 30, 2024
| evaluate | ||
| scikit-learn | ||
| peft == 0.6.2 | ||
| pytest == 7.4.2 No newline at end of file |
Collaborator
There was a problem hiding this comment.
which use case need this fix?
Author
There was a problem hiding this comment.
examples/language-modeling/run_clm.py
when this example is run with pytest >= 7.4.2 it breaks due to hardcoded path in transformers/testing_utils.py", line 129
mgawarkiewicz
approved these changes
May 7, 2024
Collaborator
|
Adam,
BTW, we request the pytest to be removed from docker in R1.16. why do you still see any issue?
Thanks,
Libin
From: Adam Stachowicz ***@***.***>
Sent: Tuesday, May 7, 2024 12:54 AM
To: HabanaAI/optimum-habana-fork ***@***.***>
Cc: Libin Tang ***@***.***>; Mention ***@***.***>
Subject: Re: [HabanaAI/optimum-habana-fork] Downgrade pytest in language modelling (PR #178)
@astachowiczhabana commented on this pull request.
________________________________
In examples/language-modeling/requirements.txt<#178 (comment)>:
@@ -5,3 +5,4 @@ protobuf
evaluate
scikit-learn
peft == 0.6.2
+pytest == 7.4.2
examples/language-modeling/run_clm.py
when this example is run with pytest >= 7.4.2 it breaks due to hardcoded path in transformers/testing_utils.py", line 129
-
Reply to this email directly, view it on GitHub<#178 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGLGHZOJ7KXCJ6VVNJJVBXLZBCCBPAVCNFSM6AAAAABGUOHVJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSGM2TKMZXGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
|
Unmatched PR |
astachowiczhabana
pushed a commit
that referenced
this pull request
Mar 11, 2025
* enabling accuracy tests for mbxp gsm8k datasets * CI linter fix * make style * eval fix * eval fix 2 * code improvement removed default paths to internal locations, moved target acc to file * removed unused dependencies --------- Co-authored-by: Rafal <rbogdanowicz@habana.ai>
rbogdano
added a commit
that referenced
this pull request
Mar 11, 2025
* enabling accuracy tests for mbxp gsm8k datasets * CI linter fix * make style * eval fix * eval fix 2 * code improvement removed default paths to internal locations, moved target acc to file * removed unused dependencies --------- Co-authored-by: Rafal <rbogdanowicz@habana.ai>
astachowiczhabana
pushed a commit
that referenced
this pull request
Mar 31, 2025
* enabling accuracy tests for mbxp gsm8k datasets * CI linter fix * make style * eval fix * eval fix 2 * code improvement removed default paths to internal locations, moved target acc to file * removed unused dependencies --------- Co-authored-by: Rafal <rbogdanowicz@habana.ai>
rbogdano
pushed a commit
that referenced
this pull request
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pytest version in language modelling as a temporary measure untill TF 4.39.
(final fix: huggingface/transformers#29154)