[SW-182028] - set ds config "reduce scatter" to false#173
Merged
Conversation
- FlanT5 is giving a perf drop with "reduce_scatter" value True in DS config Signed-off-by: vineethanandh <vineethanandh@habana.ai>
libinta
approved these changes
Apr 18, 2024
astachowiczhabana
pushed a commit
that referenced
this pull request
Apr 22, 2024
- FlanT5 is giving a perf drop with "reduce_scatter" value True in DS config Signed-off-by: vineethanandh <vineethanandh@habana.ai>
MohitIntel
changed the title
astachowiczhabana
pushed a commit
that referenced
this pull request
Apr 24, 2024
- FlanT5 is giving a perf drop with "reduce_scatter" value True in DS config Signed-off-by: vineethanandh <vineethanandh@habana.ai>
astachowiczhabana
pushed a commit
that referenced
this pull request
Apr 24, 2024
- FlanT5 is giving a perf drop with "reduce_scatter" value True in DS config Signed-off-by: vineethanandh <vineethanandh@habana.ai>
astachowiczhabana
added a commit
that referenced
this pull request
Mar 4, 2025
* Squash deepseek commit * Update optimum/habana/transformers/modeling_utils.py Co-authored-by: Yaser Afshar <yaser.afshar@intel.com> --------- Co-authored-by: Yaser Afshar <yaser.afshar@intel.com>
astachowiczhabana
added a commit
that referenced
this pull request
Mar 31, 2025
* Squash deepseek commit * Update optimum/habana/transformers/modeling_utils.py Co-authored-by: Yaser Afshar <yaser.afshar@intel.com> --------- Co-authored-by: Yaser Afshar <yaser.afshar@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the deepspeed config of summarization models to
run with "reduce_scatter" : false by default.
Fixes # (issue)
FlanT5 performance issue where the 8x performance drops to 5% when ran with deepspeed.
Before submitting