sarkar/Fix barrier#124
Merged
Merged
Conversation
libinta
approved these changes
Mar 20, 2024
astachowiczhabana
pushed a commit
that referenced
this pull request
Feb 5, 2025
* add changes for fix * add keepmoduleonhosst, modfy quant json * remove buffer check * add llama 405 checks * remove hardcoded path, reuse module on host check * fix: undefined variable * remove unused import --------- Co-authored-by: Your Name <you@example.com>
jaygala223
pushed a commit
that referenced
this pull request
Feb 13, 2025
jaygala223
pushed a commit
that referenced
this pull request
Feb 13, 2025
jaygala223
pushed a commit
that referenced
this pull request
Feb 14, 2025
ugolowic
pushed a commit
that referenced
this pull request
Feb 14, 2025
xinyu-intel
pushed a commit
that referenced
this pull request
Mar 4, 2025
* add changes for fix * add keepmoduleonhosst, modfy quant json * remove buffer check * add llama 405 checks * remove hardcoded path, reuse module on host check * fix: undefined variable * remove unused import --------- Co-authored-by: Your Name <you@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For 1x, barrier() will cause an error, so putting barrier() inside a check
Fixes # (issue)
Before submitting