-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for migration of report queries #30
base: main
Are you sure you want to change the base?
Conversation
bytesTotal: { | ||
name: 'Total Kilobytes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found reports config file - seems a good idea to keep all the configs in one place (more transparent for future contributors).
I copied it over here (to experiment with) and added the queries.
I wouldn't be able to add the queries unless the format supports multiline strings - so just saved in JS.
Actually it is required to be readable with python - YAML?
publish(sql.type, { | ||
type: 'table', | ||
schema: 'reports', | ||
tags: ['crawl_reports'] | ||
}).query(ctx => constants.fillTemplate(sql.query, params)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reports
dataset we could store intermediate aggregated data - it's easier to check for data issues in BQ than in GCS.
Cloud Function then will pick fresh rows and save them to GCS.
I think we could be fine with a table per chart type, e.g httparchive.reports.timeseries
:
- date (partition)
- metric (cluster)
- timestamp
- client (cluster)
- p10
- p25
- p50
- p75
- p90
const params = { | ||
date: constants.currentMonth, | ||
rankFilter: constants.devRankFilter | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query parameters.
I found only date
.
Please list all the required and add the queries to test them with.
@tunetheweb here is a demo version that needs to be discussed. And I have no idea what to do with lenses and 2 more requests (see in description).. |
We want to replace legacy reports script https://github.com/HTTPArchive/bigquery/tree/master/sql
This is the implementation that follows previous discussion.
TODO list:
crawl_complete
reports
)Supports features: